search

bootstrap-ruby / bootstrap_form

Official repository of the bootstrap_form gem, a Rails form builder that makes it super easy to create beautiful-looking forms using Bootstrap 5.
MIT License
1.64k stars 352 forks source link

Refactor check box and radio button helpers #547

Open lcreid opened 4 years ago

lcreid commented 4 years ago

One approach to solving #477 and related issues would be to implement be to make our implementation use the Rails methods for label and check_box and radio_button in a way that would make our helpers easier to use in the collection helpers.

lcreid commented 4 years ago

It looks like the Rails internals use string keys, and we use symbol keys. This could be causing all sorts of unexpected behaviour, and could require all sorts of extra code.

lcreid commented 4 years ago

Added the Bootstrap 5 label because we should take a look at this if we're making changes to the fundamental code.