search

bootstrap-ruby / bootstrap_form

Official repository of the bootstrap_form gem, a Rails form builder that makes it super easy to create beautiful-looking forms using Bootstrap 5.
MIT License
1.64k stars 352 forks source link

Fix Rails 6.1 tests on master #586

Closed thimo closed 3 years ago

thimo commented 3 years ago

This PR fixes the issues with testing against Rails 6.1. The changes applied here are the same as those already applied on the bootstrap-5 branch. Also solves a few Rubocop offences.

thimo commented 3 years ago

Github Action "Lint" fails with the following message:

Could not set up API to Code Review site for Danger For your GitHub repo, you need to expose: DANGER_GITHUB_API_TOKEN You may also need: DANGER_GITHUB_HOST, DANGER_GITHUB_API_BASE_URL, DANGER_OCTOKIT_VERIFY_SSL

Is there someone who can set this up correctly? Lint only runs on PR's, so it's not a problem for direct commits. Not sure if this is on purpose?

lcreid commented 3 years ago

I can take a look, but I didn't set up Danger so it may take a while for me to figure it out.

thimo commented 3 years ago

As Danger runs just fine in the Travis tests I can image there being a DANGER_GITHUB_API_TOKEN env variable in Travis that you can copy to the Github bootstrap_form project. But I'm neither familiar with Travis nor Danger. Do you have access to Travis?

thimo commented 3 years ago

Additionally removed .rubocop_todo.yml and mostly applied the same Rubocop offences fixes as I did to the bootstrap-5 branche.