search

bootstrap-ruby / bootstrap_form

Official repository of the bootstrap_form gem, a Rails form builder that makes it super easy to create beautiful-looking forms using Bootstrap 5.
MIT License
1.64k stars 352 forks source link

fix: Auto-correct RuboCop issues #603

Closed olleolleolle closed 3 years ago

olleolleolle commented 3 years ago

This PR fixes the remaining linting issues.

olleolleolle commented 3 years ago
There was a Faraday deprecation notice, which came from Octokit. But also an octokit auth failure. Perhaps I do not have the correct credentials? This is perhaps linked to the fix-ci branch in #602. ``` WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0. While initializing your connection, use `#request(:authorization, ...)` instead. See https://lostisland.github.io/faraday/middleware/authentication for more usage info. ```
lcreid commented 3 years ago

Yes. I just haven't had the time or motivation to figure out how to run Danger through GitHub actions. It's fairly well documented, but it wasn't completely clear to me how to store the credentials, so I haven't done it yet. If you want to take a run at it, I'd be happy to review the PR.