search

bootstrap-ruby / bootstrap_form

Official repository of the bootstrap_form gem, a Rails form builder that makes it super easy to create beautiful-looking forms using Bootstrap 5.
MIT License
1.64k stars 351 forks source link

Set required and aria on input when input is required #605

Closed CharlieWinkwaves closed 2 years ago

CharlieWinkwaves commented 2 years ago

fixes #604

CharlieWinkwaves commented 2 years ago

@lcreid The tests and rubocop are fixes

lcreid commented 2 years ago

@CharlieWinkwaves Would you be able to create another PR of this code against the bootstrap-5 branch? We're at that awkward time where we have two active branches, since we're about to release version 5 of this gem for Bootstrap 5. Thanks in advance if you can, and no worries if you can't.

CharlieWinkwaves commented 2 years ago

@lcreid I created a pr for bootstrap 5 https://github.com/bootstrap-ruby/bootstrap_form/pull/606

CharlieWinkwaves commented 2 years ago

@lcreid About the failing test for rails 7. I have no clue why they fail I did run all the test locally with ruby 2.7 and Rails 7.0.0.alpha2 and they past without a problem. `» rails -v Rails 7.0.0.alpha2 » ruby -v ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-darwin20] » bundle exec rake test Run options: --seed 4392

Running:

..................................................................................................................................................................................................................................................

Finished in 1.060287s, 228.2401 runs/s, 265.0226 assertions/s. 242 runs, 281 assertions, 0 failures, 0 errors, 0 skips`