bootstrap-ruby / bootstrap_form

Official repository of the bootstrap_form gem, a Rails form builder that makes it super easy to create beautiful-looking forms using Bootstrap 5.

MIT License

1.64k stars 352 forks source link

Enable include hidden #627

Closed a5-stable closed 2 years ago

a5-stable commented 2 years ago

Fixes https://github.com/bootstrap-ruby/bootstrap_form/issues/215

Enable include_hidden option with collection_check_boxes:

donv commented 2 years ago

This PR looks good, but the "danger" linting fails. Anybody an idea why the linting fails?

donv commented 2 years ago

This might be the problem: https://github.com/danger/danger/issues/1103

a5-stable commented 2 years ago

Thanks for checking!

625 seems to mention this failure.

donv commented 2 years ago

I have committed the suggested fix for danger. @a5-stable could you rebase this PR to test the fix?

a5-stable commented 2 years ago

@donv Thank you for quick fixing. Synced to HEAD.

donv commented 2 years ago

I committed a workflow change to enable secrets for fork-PRs for danger. Could you rebase again and see if it helps? If it doesn't help I will do a manual review of this PR.

a5-stable commented 2 years ago

@donv Thanks! I did but workflow seems failed at loading danger.

donv commented 2 years ago

Thanks @a5-stable for the PR and the CHANGELIG entry! The problem with danger will take longer to resolve, so I'll merge this PR now.