search

bootstrap-ruby / bootstrap_form

Official repository of the bootstrap_form gem, a Rails form builder that makes it super easy to create beautiful-looking forms using Bootstrap 5.
MIT License
1.64k stars 352 forks source link

Rename the default layout to "vertical" ? #687

Closed donv closed 10 months ago

donv commented 1 year ago

As stated in the Bootstrap docs:

"forms will by default stack vertically"

The current name, "default", does not actually hold any meaning. Also, the default can be changed to "inline" or "horizontal".

I propose we change the name of the default layout to "vertical".

What do you think?

lcreid commented 1 year ago

I agree that vertical would be much more explicit and clear. I would suggest we continue to recognize default, but remove all mention of it from the documentation. Bonus marks for outputting a deprecation message if the user uses default.

donv commented 10 months ago

I'll start working on this now.