search

bootstrap-ruby / rails-bootstrap-navbar

Easily generate a Bootstrap navbar in your Rails app
http://bootstrap-ruby.github.io/rails-bootstrap-navbar
MIT License
60 stars 13 forks source link

Indentation #11

Closed Sammidysam closed 11 years ago

Sammidysam commented 11 years ago

The indentation for this project is insanely weird. Wouldn't it be good to get a more normal indentation? Maybe keep a consistent indent of a tab instead of sometimes two spaces and sometimes a tab? Or maybe, keep a consistent indent of two spaces, if that is preferred. Having different indent offsets makes reading the code pretty confusing.

manuelmeurer commented 11 years ago

You're right, using the same indentation everywhere would definitely be nice. I don't see it as a huge problem, though, if you configure your editor to show tabs as two spaces you should almost not notice it. Anyways, I'm planning a major update to this project, after which we can fix the indentation method.

julescopeland commented 11 years ago

Yeah - sorry about that - I wrote this ages ago on an old laptop with TextMate set up weirdly...

Sammidysam commented 11 years ago

I can't really handle tabs being less than 4 spaces (4 or 8 is okay, but anything less or more I can't handle), so I will keep noticing it for now. After or during your major update you can easily just use Emacs or Vim to auto-format stuff after settings indentation settings that you like.

manuelmeurer commented 11 years ago

Indentation should be fixed now. :smiley:

Sammidysam commented 11 years ago

It definitely looks nicer.