search

bootstrap-ruby / rails-bootstrap-navbar

Easily generate a Bootstrap navbar in your Rails app
http://bootstrap-ruby.github.io/rails-bootstrap-navbar
MIT License
60 stars 13 forks source link

Add an example to README #13

Closed mirelon closed 8 years ago

mirelon commented 8 years ago

README is just referring to bootstrap-navbar. But there is an example which is not usable, because some of the methods are overriden in NavbarHelper (e.g. brand_link has 3 parameters instead of 2)

manuelmeurer commented 8 years ago

Hmm, not sure what you mean. This gem doesn't add any functionality nor does it override anything. I'm also not sure which NavbarHelper you refer to and to my knowledge, there is no brand_link method anywhere. Could you elaborate?

mirelon commented 8 years ago

I am sorry, it was just incompatibility of https://github.com/bootstrap-ruby/bootstrap-navbar/blob/master/lib/bootstrap-navbar/helpers/bootstrap3.rb#L29 and https://github.com/seyhunak/twitter-bootstrap-rails/blob/master/app/helpers/navbar_helper.rb#L154