search

bootstrap-ruby / will_paginate-bootstrap

Integrates the Twitter Bootstrap pagination component with will_paginate
MIT License
388 stars 160 forks source link

Adds pagination class to the ul so it works with Bootstrap 3 too #12

Closed miharekar closed 11 years ago

miharekar commented 11 years ago

Fixes #11 I created. It is backwards compatible with Bootstrap 2 if you don't mind the extra class.

fguillen commented 11 years ago

+1, I'm using this fork and it works as a charm

nickpad commented 11 years ago

Thanks, that looks great. I'm just going to tweak this slightly before I merge to create a separate renderer class for bootstrap 3, so exactly the right markup is generated whether you're on v2 or v3.

miharekar commented 11 years ago

Well you can do that for 3 with will_paginate just add class: nil option but for 2 you probably will need an option to disable the extra style, yea.

nickpad commented 11 years ago

Hi Miha - I decided to maintain compatibility with versions 2 and 3 for the moment by letting users pass in an option to generate appropriate markup for bootstrap 3. Thanks for the pull request nonetheless.