Closed QuincyLarson closed 11 years ago
I actually aleready did that in pull #12 but @nickpad said he's gonna make separate renderer class for bootstrap 3 :wink:
Hi Michael - i've now added an option for generating bootstrap 3-compatible markup without the extra outer div, so am going to close this. Thanks for the pull request though!
Hi Nickpad,
Greetings from San Francisco.
Big fan of your will_paginate-bootstrap gem!
It wasn't compatible with Bootstrap 3 rc1, but I figured out how to make it so.
In Bootstrap 2:
In Bootstrap 3:
It's a very subtle difference, and it's kind of annoying they decided to make such an irrelevant change. So my fix was to put the class declaration in the ul tag. I didn't dig deeply enough to remove the now-irrelevant class declaration from the div tag - it doesn't seem to matter, but it should be cleaned up somewhere.
Thanks and keep making time-saving tools like this!