bootstrap-styled / v4

:rocket: twbs/bootstrap V4 UI Components made with bootstrap-styled. Work with css-in-js, react, styled-components, and Bootstrap Styled utilities
https://bootstrap-styled.github.io/v4
MIT License
116 stars 22 forks source link

feat(button): add props.color option 'white' #179

Closed maxobaxo closed 4 years ago

maxobaxo commented 4 years ago

Add the option to pass 'white' as props.color value to an instance of the Button component. Previously, console would log propType error as Button.propTypes.color did not allow for 'white' as an option. This change will allow 'white', and prevent the error.

this commit closes #178

v4

Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the License.

kopax commented 4 years ago

Thanks, I am releasing a new version now, could please have a quick check and test it? Best!

kopax commented 4 years ago

:tada: This PR is included in version 3.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: