BAlert documentation mentions "dismissed" as the event, while code emits "close" - Githubissues

bootstrap-vue-next / bootstrap-vue-next

Early (but lovely) implementation of Vue 3, Bootstrap 5 and Typescript

https://bootstrap-vue-next.github.io/bootstrap-vue-next/

MIT License

1.06k stars 105 forks source link

BAlert documentation mentions "dismissed" as the event, while code emits "close" #1942

Closed jcherniak closed 1 month ago

jcherniak commented 1 month ago

Describe the bug

In the documentation for BAlert, it states there is a "dismissed" event that is triggered on close.

In the code however, it emits a "close" event.

Either the docs or code needs to be updated so they match. I'd provide a pull request, but I don't know which the project would prefer to change.

Reproduction

https://stackblitz.com/edit/github-1e5qxm?file=src%2FApp.vue

Used Package Manager

npm

Validations

[X] Have tested with the latest version. This is still alpha version and sometime things change rapidly.
[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

stackblitz[bot] commented 1 month ago

Start a new pull request in StackBlitz Codeflow.

github-1e5qxm (Open reproduction)