bootstrap-vue / bootstrap-vue

BootstrapVue provides one of the most comprehensive implementations of Bootstrap v4 for Vue.js. With extensive and automated WAI-ARIA accessibility markup.
https://bootstrap-vue.org
MIT License
14.52k stars 1.87k forks source link

Bootstrap-Vue V2.0.0-rc.12 Tracker #2173

Closed tmorehouse closed 5 years ago

tmorehouse commented 6 years ago

This issue is for tracking progress of the next release of Bootstrap-Vue.

We will be updating this list as PRs are added/merged.

If you have bug reports or feature requests, please open a new issue rather than comment here.


New Features

Enhancements

Fixes

Documentation

Unit Testing

Postponed until later release

New Features

Enhancements

Fixes

Documentation

Unit testing

Other

tmorehouse commented 5 years ago

We're looking for some help with adding documentation re Vue CLI v3

robcresswell commented 5 years ago

I'll take it. Used the CLI a fair bit so should have enough know-how.

noahbornstein commented 5 years ago

Great work all - love this project and really appreciate it! Any rough estimates on next release date? (days? weeks? months?) Thanks!

tmorehouse commented 5 years ago

Next release will be in more than 1 second into the future.

Hoping we can get something out this week. We may not have all the kinks we want ironed out, but at least there will be a lot of fixes.

ghenry commented 5 years ago

Any chance of this in the release? https://github.com/bootstrap-vue/bootstrap-vue/issues/1564

tmorehouse commented 5 years ago

Probably not in this coming release (which we are hoping to have out this week).

It wouldn't be something we could easily add to form-group, as this feature relies on specific markup (where the label is after the input), and doesn't handle input sizing based on their custom CSS (which is not part of bootstrap V4.1, and is using some vars no longer in V4.1)

But you can definitely wrap a regular input in the required markup and classes, and make a re-usable custom component.

TitanFighter commented 5 years ago

Hi @robcresswell i If you have not started yet preparation of Vue-cli v3 usage documentation, I can take it, in order to make a new release with updated info. I just moved my project from cli v2 to cli v3 and it was quite easy.

robcresswell commented 5 years ago

I've started, just need a free evening to verify and push stuff :)

TitanFighter commented 5 years ago

@robcresswell just want to mention two things (just in case):

  1. Tree shaking (No need to import components individually)
  2. For old browsers (in my case for iOS 9), it was necessary to add:
    module.exports = {
    ....
    transpileDependencies: ['bootstrap-vue']
    }

    to vue.config.js in order to solve Unexpected keyword 'const'. Const declarations are not supported in strict mode.

tmorehouse commented 5 years ago

Is that from importing Bootstrap-Vue via the /es/ modules directory? It should all be pre-transpiled

TitanFighter commented 5 years ago

It is not imported, there is no any import xyz from "xyz" at the top of vue.config.js. We simply need to add a string or regex to transpileDependencies.

  1. From the Guide:

If one of your dependencies need polyfills, you have a few options:

  1. If the dependency is written in an ES version that your target environments do not support: Add that dependency to the transpileDependencies option in vue.config.js. This would enable both syntax transforms and usage-based polyfill detection for that dependency.
  2. ...
  3. ...
  1. From the Reference

transpileDependencies Type: Array<string | RegExp>

Default: []

By default babel-loader ignores all files inside node_modules. If you want to explicitly transpile a dependency with Babel, you can list it in this option.


Regarding:

It should all be pre-transpiled

... bootsrap-vue does not work with iOS 9 from the box.

From Browser Support -> JS:

BootstrapVue is written in Vue! So this is up to your project and bundler which browsers are supported. If you want to support older IE, Android and IOS devices, you may want to use Babel Polyfill.

I do not know for what target browsers bootstrap-vue is pre-transpiled, but it seems that the iOS 9 is out of that range.

EDITED: If you are talking about importing Bootstrap-Vue via the /es/ modules directory in main.js, then no, I import it as usual -> import BootstrapVue from 'bootstrap-vue'.

tmorehouse commented 5 years ago

In package.json we point module (and js:next) to the pre transpiled /es/* build, so it should pick the es build over the src or dist versions.

It might be because of our bablerc/browserlistrc files may not be targeting iOS9 properly.

Also note that there are two sub modules that are considered not "pure" which add in a couple of poly fills that could get filtered out (notably utils/object and utils/array)

Was going to add these exceptions to package.json to let webpack/etc know they have side effects.

TitanFighter commented 5 years ago

Just changed import BootstrapVue from 'bootstrap-vue' to import BootstrapVue from 'bootstrap-vue/es' + removed transpileDependencies: ['bootstrap-vue'] and checked on iOS 9 -> it works :) One more thing to mention in the docs :)

tmorehouse commented 5 years ago

Interesting. It should auto pick the es/ modules based on our package.json file entries

TitanFighter commented 5 years ago

Just double checked without /es and without transpileDependencies and it works... Strange. Need more time to find out why previous attempts were unsuccessful.

tmorehouse commented 5 years ago

Are you using rc.11 or the dev branch for testing?

TitanFighter commented 5 years ago

rc.11

tmorehouse commented 5 years ago

Ok.. is it possible to check against the latest dev branch?

TitanFighter commented 5 years ago

For some reason I can not replicate error on iOS 9 using rc.11. Yes, I can check the latest dev branch. In about 1 hour I will come back with a report.

TitanFighter commented 5 years ago

I can confirm that from the box the latest dev branch works on iOS 9.

tmorehouse commented 5 years ago

Dev branch has an updated .browserlistrc file compared to current master. So it may have better coverage for a few older browsers.

tmorehouse commented 5 years ago

@TitanFighter any luck with your recent findings/tests?

TitanFighter commented 5 years ago

Unfortunately I can't find why Bootstrap-vue didn't work on iOS 9. If I find it, I will inform. rc11 and the latest dev work ok.

krgaurav1992 commented 5 years ago

Can you please add support for raw html so that icons can be inserted with breadcrumbs ?

What I want is: { text: '<span class="lnr lnr-home"></span>', to: '/' }

jsancho-gpl commented 5 years ago

Hi people, thank you so much for your excellent work! Is there any estimation for the rc12 release date?

pi0 commented 5 years ago

@jsancho-gpl today :angel:

tmorehouse commented 5 years ago

BoostrapVue v2.0.0-rc.12 has been released today!

alexandernst commented 5 years ago

:party_parrot: