bootstraptheme-for-typo3 / fluidcontent_bootstrap

TYPO3 extension Fluid Content - Bootstrap: Fluid Content Elements for Twitter Bootstrap using VHS
http://fluidtypo3.org
15 stars 21 forks source link

Fluid Content Type: Column Row additionalClass does not display #120

Closed manmath closed 10 years ago

manmath commented 10 years ago

I used fluidcontent_bootstrap as Column Row and I tried to add Additional Class to each column but it did not display. I try to debug object {sectionObject} and I found that fluid template does not print {sectionObject.column.additionalClass} out.

Can you add this to your fluid template?

NamelessCoder commented 10 years ago

Hi @manmath - fluidcontent_bootstrap is deprecated in favor of https://github.com/bootstraptheme-for-typo3/fluidbootstraptheme - and I believe the issue is fixed in that extension. You are welcome to create a pull request with this change (please check contribution guidelines before you do), but the team no longer actively maintains the fluidcontent_bootstrap extension.

fschaeffer commented 9 years ago

Hello Claus,

is there any migration tools / migration path available to move a working site from fluidcontent_bootstrap to the new fluidbootstraptheme? And is there any documentation how to build a provider extension and to disable the default pages in fluidbootstraptheme? And a migration path from own built provider extensions to this new package? I appreciate this new extension but need some advice how to migrate an existing page from fluidcontent_bootstrap/fluidpages_bootstrap_own to this new extension if this is the one where features are added / bugs are fixed...

randomresult commented 9 years ago

There is an update feature in the Extensionmanager to migrate from old fluidconent_bootstrap to theme. But please "MAKE A BACKUP YOU DAMN COWBOY" (@namelesscoder) before using it. You can also disable the pages in the Extensionsettings too. Just go to Extensionmanager and there to settings of theme. You can there disable both, pages and contentelements. I dont understand the "And a migration path from own built provider extensions to this new package?" part of your question... what do u mean? Cheers.

fschaeffer commented 9 years ago

Thanks for your quick reply. This helped a lot to identify the pitfalls and finally migrate the page.

First to note, I use fluidXXX since almost 1,5 years and started with the first versions for 6.x, that might explain the different issues I had due to some updates/upgrades in that extensions...

For the record, I had to adjust the class.ext_update.php and add

//select all Contentelements from Fluidcontent_bootstrap and migrate them

        $res = $GLOBALS['TYPO3_DB']->exec_SELECTquery('*', 'tt_content', '`tx_fed_fcefile` LIKE "fluidcontent_bootstrap:%"', 'tx_fed_fcefile', '', '');

        while ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) {
            $replaced = str_replace('fluidcontent_bootstrap', 'fluidbootstraptheme', $row['tx_fed_fcefile']);

            $GLOBALS['TYPO3_DB']->exec_UPDATEquery('tt_content', 'tx_fed_fcefile = "'.$row['tx_fed_fcefile'].'"', array('tx_fed_fcefile' => $replaced));
            $updated.= $GLOBALS['TYPO3_DB']->sql_affected_rows() . ' rows have been updated for '.$row['tx_fed_fcefile'].'';
            $updated.= '<br />';
        }
randomresult commented 9 years ago

Great it worked! If you want, you can create a PullRequest and we will merge it after testing.

fschaeffer commented 9 years ago

done in https://github.com/bootstraptheme-for-typo3/fluidbootstraptheme/pull/230

One more question, in my own extension I defined some plugin.myextension.setting.XX which in older versions was available in fluid. Now if I debug the {setting} inside my templates I only get the settings for fluidbootstraptheme ... Is there a special setting I have to take care of?

randomresult commented 9 years ago

Take a look into our contentelements. They have an option "usetyposcript". I think you need to register your element in the contentcontroller and then use this option. Your setting will then be respected. Take a closer look here https://github.com/bootstraptheme-for-typo3/fluidbootstraptheme/blob/development/Classes/Controller/ContentController.php

fschaeffer commented 9 years ago

Thanks for your input. I just had a look in that ContentController, but as I only use Page Templates I just checked PageController and found no way to do it ....

fschaeffer commented 9 years ago

Thanks, for the record, the settings are imported when using the correct plugin.tx_<myextension>.settings key in setup / constants ....

Thanks for all your help