search

bootstrapworld / codemirror-blocks

A library for building language-specific, CodeMirror-friendly editors that are a11y-friendly.
28 stars 11 forks source link

Clean up all `var`s #124

Closed sorawee closed 5 years ago

sorawee commented 6 years ago

We have webpack. Probably should use let and const everywhere for sanity, and let webpack transforms them to var for us.

schanzer commented 6 years ago

Totes. There's at least one area in the codebase where var is required (assignClonePostion() in Renderer.js), but otherwise we should definitely take a cleanliness pass over this.

schanzer commented 5 years ago

Given how much has been rewritten for new-reactify, I'm labeling this as fixed in that branch.