search

bootstrapworld / curriculum

6 stars 7 forks source link

live on web - buggy link #1133

Closed retabak closed 2 years ago

retabak commented 2 years ago

https://bootstrapworld.org/materials/fall2022/en-us/lessons/data-collection/pages/survey-design.html I vaguely remember this happened once before?

image

schanzer commented 2 years ago

@ds26gte I can't figure out why one of the links on this page works, but the other doesn't. Can you take a look?

ds26gte commented 2 years ago

Artifact of optional pages being necessarily processed in alphabetical order (no other natural order suggests itself for optionals). survey-design.adoc was referring to survey-brainstorm.adoc and survey-hacking.adoc. It got the title for the former because b < d, but not the latter because h > d. (The same survey-design.adoc in solution-pages/ got everything correct, because solution-pages/ are processed after all the pages/ are.)

Pushed fix whereby the title text is calculated via ad-hoc grep beforehand (and it can be updated when the file is processed by Racket, in case that produces a better title).

schanzer commented 2 years ago

Confirmed fixed!

schanzer commented 2 years ago

@ds26gte I'm seeing almost the exact same behavior in courses/data-science/resources/pages/implementation-options.html on a forced build on my machine. Can you investigate?

ds26gte commented 2 years ago

If you mean the @lesson-link{project-research-paper}, that lesson is not part of the data-science (or any!) pathway, so it is not part of the distribution and there is nothing to link to. Is this the sort of page you want in shared/langs/en-us/docroot/... somewhere?

schanzer commented 2 years ago

No - it's definitely a lesson. Why is there a restriction that lessons used with this directive be part of a pathway? Doesn't this reduce the value of your other proposed solution, that all projects actually be lessons-that-aren't-really-lessons?

@lesson-link should allow for links to lesson plans, regardless of whether they are in a pathway or not.

ds26gte commented 2 years ago

I used to copy all the lessons over to the distribution and "make" them. @flannery-denny said it was taking too much time when all she wanted was to make was one course. So I made it be "on demand".

schanzer commented 2 years ago

@ds26gte got it. Thanks!

retabak commented 2 years ago

Still seeing the same behavior!? Check it out here: https://bootstrapworld.org/materials/fall2022/en-us/lessons/data-collection/pages/survey-design.html

image

schanzer commented 2 years ago

@retabak have you tried reloading with the shift key down?

retabak commented 2 years ago

okay, I legit thought I tried that.... but I just tried it again and now it looks good!