bootstrapworld / curriculum

6 stars 6 forks source link

Review Logarithms lessons (both!) #1511

Closed schanzer closed 11 months ago

schanzer commented 1 year ago
flannery-denny commented 1 year ago
flannery-denny commented 1 year ago

@schanzer I'm going to pick up with this in the am. Can you tell me why these are two separate lessons?

schanzer commented 1 year ago

@flannery-denny they once were. No need to continue with them as separate lessons.

flannery-denny commented 1 year ago

@schanzer Please have a look at transforming-data.adoc and ask yourself whether it really needs to be written with such an unfriendly intro of garbledygook. I have been seeing an increasing amount of specialty css rules and definitions used in .adoc files and would like to encourage you not to use that as your default. It makes it harder/more time consuming for me and Rachel to edit files you've made. And it will make onboarding anyone else much more complicated if they find themselves confronted with files like this one.

schanzer commented 1 year ago

@flannery-denny aside from the easily collapsible CSS at the top of the page, can you tell me what you find unfriendly? If it's just the CSS at the top, I can move that to a separate file so you don't need to look at it.

flannery-denny commented 1 year ago

The @font-face section is ugly as all get out and goes on for several screens! long enough that it's hard to know whether there will be anything intelligible to follow.

But the kind of thing that has actually made it time consuming to clean up files you've made recently is css like this:

++++

++++

where it's effortful to decide when and when not to keep your special new formatting because I have to figure out how many times it's been applied to a file, whether it's helping or hurting edits I'm working on, and whether removing it from the spot I'm working on will break other things.

schanzer commented 1 year ago

@flannery-denny thanks - knowing what the problem is makes it much easier to identify a solution. Sounds like you're concerned about three specific files from a different lesson. I'll push a commit momentarily that resolves the issue.

flannery-denny commented 1 year ago

Thanks @schanzer. I don't necessarily need a fix in the other files. But I definitely think a fix in the file in this lesson would be worthwhile. Mostly just wanted to flag that I'm seeing more and more stuff at the top of .adoc files and wanted it to be on your radar that, while it serves a purpose, it has an impact on other authors and should be used with that cost-benefit consideration in mind.

schanzer commented 1 year ago

@flannery-denny factoring out the CSS and improving the authoring experience required a lot of learning about asciidoctor, but I think the hour was well-spent. I've pushed an update that affects transforming-axis and transforming-data, which I think will make you happy.

flannery-denny commented 1 year ago

@schanzer I love the idea of using fragments for this! What an improvement! I think that hour of learning will save gazillions of future authoring hours :)

For some reason one of the icons in transforming-axis now says FOO and the dotted circle is appearing as the inverse version of what it previously looked like.

schanzer commented 1 year ago

@flannery-denny I want to push back on the idea that students need to practice building another column their own. This is not a learning goal for the lesson, and level of comfort they need with defining filter and build functions is very minimal. I think adding more practice for them here shifts the lesson more fully in the direction of programming, when it really should stay rooted in logarithms.

retabak commented 12 months ago

Looking for Patterns

Logarithmic Functions

... to be continued!

schanzer commented 12 months ago

@retabak I've updated the exploring-countries page to fix the issues you listed. Thanks for reporting!

flannery-denny commented 11 months ago

also need to align this with the wording used in the last section of the lesson plan

schanzer commented 11 months ago

@flannery-denny I believe I've addressed all of these issues. Let me know if some of them still feel undone?

flannery-denny commented 11 months ago

@schanzer

schanzer commented 11 months ago

@flannery-denny fixed the table height. The interpretation page was a draft that never got polished, but with a little love it could easily be included! Want to take a crack at it?

schanzer commented 11 months ago

@flannery-denny I've pushed solutions for all but one of your checkboxes. I don't think it's possible come up with a meaningful set of solutions for the page where students are making models of their own.

Is the lesson ready to have slides made? I feel like now all the feedback is on the workbook pages...

flannery-denny commented 11 months ago

ready to ship once @schanzer makes slides and checks solutions