bootstrapworld / curriculum

6 stars 7 forks source link

Sidebar issues #551

Closed retabak closed 3 years ago

retabak commented 3 years ago

If you place your cursor in exactly the "perfect" place between two badges, they go crazy and 'blink' very quickly.

Also, have we considered / explored having the sidebar slide in and out of appearance more slowly? I find its fast movement a little jerky and jarring.

schanzer commented 3 years ago

@retabak I slowed down the animation a bit. Let me know what you think?

As for the badges -- if we make them all full-size, we can't fit more than one in the toolbar without it becoming cumbersome. If we make them small, they're unreadable (as @flannery-denny has pointed out in an earlier issue). Another option is to ignore the badge concept entirely, and replace them with text-only links.

Thoughts?

schanzer commented 3 years ago

An issue for @ds26gte: it looks like the textbook alignment in the Flags lesson is including a mix of codes and titles. What gives?

image

(Note: on the website, the textbook still is still hidden, so you'll need to build locally to see this)

retabak commented 3 years ago

@schanzer - I do prefer the slower speed at which the sidebar is appearing.

As for the badges: I'd be sad to see them go. I'm not sure what the solution is, given that they are unreadable at a smaller size. Is there really no way to resolve the blinking issue? Maybe @flannery-denny wants to weigh in??

schanzer commented 3 years ago

@retabak I spoke with Flannery today, and it looks like Badge concept does not scale well to other practices (Like MLR, NGSS, etc), in addition to not working out the way we'd hoped for the CC MPs. Here is the new proposal:

What do you think?

retabak commented 3 years ago

@schanzer I thought I replied to this! I'm down with this new proposal.

Just encountered another sidebar issue, however...

There is some vertically oriented text (it's purple? and maybe it says "Lessons Pathway Standards"?) but it is totally illegible. I can kinda see it when the side bar is tucked into the side of the page, and then it disappears when the sidebar pops out. I assume it's supposed to be legible to indicate to folks that the little box hanging out on the left of their screens has a purpose.

flannery-denny commented 3 years ago

@schanzer sidebar text is also off-screen for me.

schanzer commented 3 years ago

I really think we should go back to the original format, in which the sidebar is always visible on the righthand side of the lesson. We have so much space to the right! Why not use it?

flannery-denny commented 3 years ago

I'm not sure why it ended up on the left. No strong feelings.

schanzer commented 3 years ago

Moved it back to the right, and kept it always visible. Comments welcome.

flannery-denny commented 3 years ago

@schanzer as someone who often minimizes the window I'm working in, the sidebar being in a fixed position on the right is pretty annoying. Is there a way to make it so that I can expand it if I want to, like we used to be able to do from the left?

schanzer commented 3 years ago

Flannery and I talked about this tonight, and arrived at the following criteria:

retabak commented 3 years ago

I'm thinking more about this toolbar and thinking perhaps some sort of drop-down menu would better serve our purposes?

image

schanzer commented 3 years ago

The primary purpose is not simply to navigate.

@retabak we used to have the standards and badges as part of the lesson table, but @flannery-denny felt that they were getting lost. We made the decision to move these to a sidebar - similar to how the Open Up resources list their lesson alignments and metadata off to the side. If you're citing them as an exemplar, shouldn't we follow their lead?

The drop-down menu is pretty close to my comment above. But instead of dropping down, it grows up.

retabak commented 3 years ago

@schanzer - The only content off to the side on the Open Up site is there to help you navigate through the individual lesson content. I'm not seeing any alignments and metadata off to the side; can you explain what you mean? I'm seeing that Open Up lists the standards in the lesson table:

image

Obviously we don't need to do exactly what Open Up does! This sidebar continues to feel a little clunky and like it's not totally integrated. I think part of why it seems not quite right is because it's trying to do many things at once. I do like the idea of the menu growing up--but would need to see it to totally understand what you're envisioning.

As for the standards getting lost: Believe it or not, as a teacher, I think I'm sort of okay with that? When I'm using any given curriculum, I'm comforted to know that a curriculum is aligned to the standards. Once I see that the attention has been given to standards alignment, I focus on thinking about lesson instruction (how are the materials? will my kids enjoy it? is it relevant?) and trust that the curriculum authors did their due dilligence with respect to standards. Put another way: Standards are a thing that I note, with gratitude, and then I move on to thinking about instruction.

schanzer commented 3 years ago

How odd - Jen Poole had cited OpenUp as her original example of a good sidebar!

In any case, we originally had the standards in the lesson plan. This was deemed to take up too much space for something that isn't necessarily being used every day. @flannery-denny and I did some design discussion around this, which is how we arrived at the need for a sidebar (badges, showing prerequisites, etc are all part of this).

Is this something that needs to go back to the drawing board? If so, it's going to have to wait for next year. Are there tweaks we can make to the existing system in the meantime?

flannery-denny commented 3 years ago

I think we should plan to discuss sidebar as a team at next week’s meeting rather than over git. Not sure what the best way forward is at the moment.

To be clear, I gave feedback on how to make it better than the original concept because I was told that sidebar was a priority that had to happen in order to make it possible to access other lessons from within a lesson.

I was not a fan of the sidebar concept nor was I a fan of how our website addressed the standards.

On Sep 14, 2021, at 6:37 AM, Emmanuel Schanzer @.***> wrote:

 How odd - Jen Poole had cited OpenUp as her original example of a good sidebar!

In any case, we originally had the standards in the lesson plan. This was deemed to take up too much space for something that isn't necessarily being used every day. @flannery-denny and I did some design discussion around this, which is how we arrived at the need for a sidebar (badges, showing prerequisites, etc are all part of this).

Is this something that needs to go back to the drawing board? If so, it's going to have to wait for next year. Are there tweaks we can make to the existing system in the meantime?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

retabak commented 3 years ago

Agreed that this seems like something we should discuss in real time!

On Tue, Sep 14, 2021 at 7:36 PM flannery-denny @.***> wrote:

I think we should plan to discuss sidebar as a team at next week’s meeting rather than over git. Not sure what the best way forward is at the moment.

To be clear, I gave feedback on how to make it better than the original concept because I was told that sidebar was a priority that had to happen in order to make it possible to access other lessons from within a lesson.

I was not a fan of the sidebar concept nor was I a fan of how our website addressed the standards.

On Sep 14, 2021, at 6:37 AM, Emmanuel Schanzer @.***> wrote:

 How odd - Jen Poole had cited OpenUp as her original example of a good sidebar!

In any case, we originally had the standards in the lesson plan. This was deemed to take up too much space for something that isn't necessarily being used every day. @flannery-denny and I did some design discussion around this, which is how we arrived at the need for a sidebar (badges, showing prerequisites, etc are all part of this).

Is this something that needs to go back to the drawing board? If so, it's going to have to wait for next year. Are there tweaks we can make to the existing system in the meantime?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bootstrapworld/curriculum/issues/551#issuecomment-919584308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUY3SE7DGKDEBQKIYAF6JB3UB7L7VANCNFSM5BV43X4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

schanzer commented 3 years ago

OK, let's make this the focus of our next team meeting (after the one-pagers). We really need to sort this out.

retabak commented 3 years ago

A few additional thoughts on this:

image

And... some other stray thoughts:

image

schanzer commented 3 years ago

@retabak @flannery-denny

Thank you for articulating the design constraints - that helps me get a sense for where we can play, and where we can't. A few thoughts:

In other words, there's no perfect solution here. Any choice will involve tradeoffs. Do you both have a preference for which of the two options (vertical bar, everything visible vs. horizontal bar, click-to-see) you'd prefer?

flannery-denny commented 3 years ago

@schanzer I am fine with it on the right and disappearing when I make my screen small. And I agree with @retabak that the grey shadow is visually disruptive and needs to go.

If you want it on the bottom, I definitely don't want it there all the time. I find it very irritating when I am trying to view content and the amount of the screen in which I am able to view it is limited by something that someone else wants me to look at rather than what I want to look at. I had horizontal toolbars from word and windows all the time and I wish I could hide them in zoom.

retabak commented 3 years ago

I think I'm fine with it on the right, but I think it would look a lot more integrated if we could make it white (no grey, no outlines, no boxes) and also adjust it so that it starts below the Bootstrap header. Not sure if these things are possible.

On Tue, Sep 28, 2021 at 11:32 AM flannery-denny @.***> wrote:

I am fine with it on the right and disappearing when I make my screen small.

If you want it on the bottom, I definitely don't want it there all the time. I find it very irritating when I am trying to view content and the amount of the screen in which I am able to view it is limited by something that someone else wants me to look at rather than what I want to look at. I had horizontal toolbars from word and windows all the time and I wish I could hide them in zoom.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bootstrapworld/curriculum/issues/551#issuecomment-929341332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUY3SE7CXFX4OSZEKYU7UCTUEHNXJANCNFSM5BV43X4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

schanzer commented 3 years ago

@flannery-denny and @retabak want to try the toolbar on the left

schanzer commented 3 years ago

@flannery-denny and @retabak I've moved the sidebar to the left.

  1. What do you think of the new placement?
  2. How do you feel about color, shadow, and spacing between elements?
flannery-denny commented 3 years ago

@schanzer when I build the data-science pathway I get this for the landing page Screen Shot 2021-10-01 at 9 04 35 PM and I was expecting to get this Screen Shot 2021-10-01 at 9 04 25 PM

But... the more I look at it, I'm not sure which is better. Except, if you're not going to include the stuff on the left or the top, how will people navigate back to the home page? And why leave so much white space at the top?

What stands out most looking at these screenshots is that both have all that text about teaching remotely and ordering workbooks... but right here, we want to have our socks knocked off with data science! The teaching remotely materials could go on the teacher resources page? And the workbooks could go on the teacher resources page and also in the store?

When I get into the lesson itself I was expecting to still see the boot in the top left corner to maintain visual continuity (and I would expect clicking on the boot to take me back to the home page).

I expect the side bar to start in parallel (at the same y-coordinate) as the lesson plan (not sure whether it will look better aligned with the title or the materials table). I definitely don't want to see words all the way at the top of the left column like this if there is all that white space at the top of the right side of the page (speaking of which, does there need to be that much white space at the top of the page?)

Screen Shot 2021-10-01 at 9 04 43 PM

I thought we decided that all of the lesson should be shown without scrolling and people who wanted to see less could click prerequisites only.

Similarly, we decided that instead of seeing the words "Standards" we would see "CSTA standards" and they would be populated by default. Mousing over CSTA standards would reveal other options to select from.

I'm unclear on how the textbook alignment is supposed to work if a lesson aligns with lesson from IM and CMP.

Strangely, today, this MP badge is totally legible... and it's kind of a nice splash of color, as originally intended... Screen Shot 2021-10-01 at 9 16 03 PM

Finally, Rachel asked repeatedly to figure out how to get the sidebar to blend in more. I don't care if it's white or grey, but can we make the whole sidebar one color? (ie. the lesson list should be the same color as the rest of the side bar and probably doesn't need a box around it at all).

Hope that helps. Happy to discuss. Not standing on any hills yet.

schanzer commented 3 years ago

@flannery-denny

  1. The narrative pages have never had the toolbar or header when building on your machine. Those are added by the webserver, and show up when the page is viewed from www.BootstrapWorld.org. Similarly, all the lessons build without the header. The whitespace is the same as it's always been. Maybe you just didn't notice it before?

  2. We agreed that the toolbar would stay anchored on the lefthand side of the screen, and not scroll with lesson content. But that's not how the website toolbar works: it always scrolls with page content. If the lesson toolbar looks like the site toolbar, it's going to be quite strange when they behave differently! We have three choices here:

I prefer the first, followed next by the third. I think the middle option is the worst of all worlds.

  1. Replacing the standards box with a dropdown isn't something I know how to do. This one is in @ds26gte 's court.

  2. I've made the color uniform (green like the regular toolbar) and removed the boxes. The lesson table should also probably drop the green column and replace it with purple, because there's way too much green on the page when you first load a lesson. But honestly, I don't love the box-less look. I think it's less clear what the "prerequisites only" button does, since there's no visual grouping in the toolbar.

(I also hid the badges section, since we're planning to overhaul it anyway)

flannery-denny commented 3 years ago

@schanzer - While I don't think we're done, I think this sidebar looks much better! And I think the stars from the expanded view will draw people's attention to the prepreq only checkbox.

Screen Shot 2021-10-03 at 1 44 13 PM

Screen Shot 2021-10-03 at 1 43 50 PM

  1. I don't understand your response to the white space. It doesn't look to me like the header from this page will be able to fit in the horizontal space at the top of the images of the new lesson plan format above. Are you envisioning any of it appearing there? Screen Shot 2021-10-03 at 1 46 21 PM

  2. If there's no boot in the top left, how do you expect people to navigate back to home from the lesson plan?

  3. I didn't understand your 3 proposals in number 2 in the comment above. I'll add it to the agenda for Tuesday so you can share screen and show us what you're talking about.

schanzer commented 3 years ago

@flannery-denny 1: The screenshot of "what you were expecting" surprised me, because nothing has changed here. There's always been a blank space at the top and to the left of the narrative page when you build locally, and that's not going to change.

2-3: I've been working all day on something I think you'll like. I hope to have it done tonight.

retabak commented 3 years ago

Hey! Sorry I've been MIA.

There's a LOT going on in this thread and it's hard to figure out what to respond to. Eager to discuss on Tuesday. There are many many different things being considered in this sidebar revamp.

Some general thoughts:

Perhaps not TOTALLY connected to this sidebar issue, but: what did we decide on centering website content? I remember some reason we couldn't do this? Finding myself more bothered lately that the right half of my wide screen is just white space when I look at our content.

Oh, one more thing! I don't think it is obvious what that "prerequisites only" checkbox does. I know, I know. You're thinking, "Everyone knows what 'prequesite' means. What else would that checkbox do?" That said, your average teacher / website visitor will not assume that our curriculum allows for 'mixing and matching'--and they'll just ignore that checbox. (I didn't notice the checkbox until like 3 weeks ago?) That checkbox is also the only thing on the toolbar that seems to respond to whatever lesson is currently selected, which is definitely not obvious. I think teachers might think those lessons with stars are prerequisites for the entire curriculum.

I know there's a hesitation to add stuff to the lesson table, but I think it would REALLY highlight for folks that they can pick and choose from our stuff if there was a row in the table that said, "before teaching this lesson, your students must master: X, X, and X." I propose that we ditch the "preparation" row (which I find quite useless and redundant) and stick this other much more important row in its place.

schanzer commented 3 years ago

Thanks to some heroic programming by Dorai, I was able to spend tonight styling the sidebar as a replacement for the website sidebar. To view the full version (which has the top filled in, unlike the local version @flannery-denny was pointing out), click here.

@retabak I want to get your take on this before I reply to your other issues. We can do that in our meeting tomorrow.

schanzer commented 3 years ago

Now that we have separate, smaller issues for the remaining work, I'm going to close this. If @retabak or @flannery-denny object, feel free to re-open. Bear in mind that we can always look at closed issues, so this conversation is still stored for posterity!