bootstrapworld / curriculum

6 stars 6 forks source link

Content Review of 5 CODAPified Lessons #592

Closed retabak closed 2 years ago

retabak commented 3 years ago

Looking for feedback on lesson content of CODAP Data Science Pathway!

  1. displaying-categorical-data
  2. table-methods
  3. method-chaining
  4. random-samples
  5. grouped-samples

I've collected some stray thoughts here.

schanzer commented 3 years ago

Displaying Categorical Data

Table Methods

Method Chaining

Random Samples

Grouped Samples

retabak commented 3 years ago

I've revised the "Displaying Categorical Data" lesson. @schanzer - do you want to take another look before @flannery-denny does? Some responses to your questions/ comments below.

Displaying Categorical Data

Table Methods I ALSO started looking at "Table Methods," but wanted to run some questions by you, first. (Haven't yet made any revisions to this lesson.)

Will work on remaining 3 lessons asap.

schanzer commented 3 years ago

@retabak the changes look good! Thanks for turning them around so quickly. I pushed a small commit (c23041281) which uses asciidoctor "blocks" to wrap .lesson-instruction around multiple things. I'd recommend taking a gander just so you can use it in the future.

As for Table Methods:

retabak commented 3 years ago

@schanzer Updated Table Methods lesson! I think I responded to all feedback.

A few notes:

Random question: When I've added images, for some reason my computer is naming them ".PNG" rather than ".png" (like all the other image files we use). Is this a problem? I can go through and fix if needed; have only added 3 or so images at this point. (I think I should probably postpone adding images anyhow, because it's a bit of a pain in the butt; as I ask this question, I am recalling your advice to add them all at the end.)

schanzer commented 3 years ago

@retabak

  1. I think this is a fine place to start. Can you use a screenshot for which the range is something other than any? This just happens to be the most confusing one of all. Maybe it would be useful to send them on a scavenger hunt as well: "find a transformer whose range is X..."? I pushed a fix for the numbered items, which requires (get this) asciidoc column format a, which means "any asciidoc directives could appear inside this column". Check out commit cfffacc42 to see what it looks like.

  2. yeah, I'd just remove this

  3. It doesn't look like you removed the third question (about codap's behavior). Are you still planning to?

  4. Filename capitalization will matter in some cases. Surely there's a way to tell windows to use lowercase extensions? What program do you use for images?

ALSO When you're using directives like @ifproglang{}, make sure you don't mix them in with content unless they are truly inline. For example, your latest commit added the following:

* Can you fill in the code for the other grouped samples? @ifproglang{pyret}{
* When you're done, type these definitions into the Definitions Area.}

The ifproglang appears in the first bullet, but it has nothing to do with that bullet at all! I'd recommend the following instead:

* Can you fill in the code for the other grouped samples? 
@ifproglang{pyret}{
* When you're done, type these definitions into the Definitions Area.
}
flannery-denny commented 3 years ago

@retabak. Ask @schanzer to talk you through how to use directives to signal which part of the lesson is what you expect teachers to say out loud to teachers in lesson plans.

You are not using those distinctions so the formatting is inconsistent (lots of randomly bolded text) and it's easier to learn now than for us to go fix all of the pages later.

(I don't remember, but I could figure it out by looking at lesson plans I've worked on if he doesn't remember.)

One of us should add that information to the useful asciidoc commands file. Are you down to take that on?

flannery-denny commented 3 years ago

Displaying Categorical Data -

retabak commented 3 years ago

Re: One of us should add that information to the useful asciidoc commands file. Are you down to take that on?

Yep! I'll take that on.

And, as you correctly observed, I was totally guessing about those directives/signals, so am grateful for the nudge.

retabak commented 3 years ago

@flannery-denny THANKS for the feedback! Sorry again about time lost trying to build these lessons.

I addressed and checked off 5 of your concerns - but wanted more feedback on the first two items. Let me know what you think.

flannery-denny commented 3 years ago

Table Methods:

Introducing Function Definitions

Order Tables:

Building Columns:

flannery-denny commented 3 years ago

@retabak Generally speaking, I am seeing a lot of bolding and highlighting of things in your lesson plans that don't follow convention (Not your fault! This is part of the learning curve, but I wish you'd gotten feedback on it sooner...)

Lesson formatting used to be really bananas. We made directives to standardize it across lessons and make it easy to adjust for our entire repository if we were to decide we have better formatting ideas down the road. Directives allow us to flag functions, new vocab words, directions to students, etc. Nearly all bolding and highlighting in lesson plans should happen through those directives. Some of them are described in the useful asciidoc commands file. Whatever would be useful to you to know about and isn't there should be added. Holler if you need help making sense of it and you and @schanzer don't discuss it in the other conversation about directives I suggested. I won't comment about it in the other lessons I'm reading - assume you will generalize this feedback and make use of it in all lesson plan files.

flannery-denny commented 3 years ago

Chaining Methods

Design Recipe Practice

Chaining

flannery-denny commented 3 years ago

Grouped Samples

flannery-denny commented 3 years ago

Random Samples

flannery-denny commented 3 years ago

@retabak. Done with feedback for now. Need to see how the other pages interplay with codap before giving more feedback on lesson plans.

shriram commented 3 years ago

The goal was to have Pyret and CODAP+T be highly compatible. The upper-/lower-case thing is a bit of a nuisance for sure. It's on my agenda to see what we can do about that. But we can use the same terminology for both; that way the transition to Pyret will be smoother ("remember datatypes? you already saw them…").

flannery-denny commented 2 years ago

@retabak Is this issue ready to be closed or are you still working on something?

retabak commented 2 years ago

@flannery-denny Closing!