Misc workbook improvements

schanzer commented 3 years ago

DS workbook.

[x] Booleans - can we make the the "Computer Returns" @fitb be the right length now? (pdf p 10)
[x] p105 - Describing Relationships - the answer text needs to be smaller font in order to fit on the number of lines provided.
[x] page 62. Is it possible to get the tops and bottoms of the two histograms to line up with each other?
[x] p53 Chaining Order Matter 2 - On most of our pages the number and match are on one line. On this page the solution is beneath the number and it looks less tidy. There is plenty of space.
[x] p88 - Matching solutions to histograms. C reads as copyright symbol and for some reason 4 and A are not near each other on the page
[x] Chaining methods has gender when it should have sex for no 8 (pdf p 44) - ES-are you saying you would rather I misspell "sex" instead? FD - either misspell sex because it's the title of a column on the table or if you'd like to misspell a column title that isn't there, feel free to pick a word that isn't gender for your fictional column
[x] applying functions - table proportioning is weird - should preference space for answer writing (pdf p 11)
[x] Lookup questions could use more vertical space between the three sections (pdf p 26)
[x] Adopt formatting from my dataset (pdf p. 55 for the new page I made about can it be answered - it's much clearer)
[x] p118-120 - Blank Design Recipes - Any way to give a little more space for writing directions at the top instead of having so much blank space at the bottom?

Algebra pyret workbook

[x] page 69 - simple inequalities - curious about the formatting of true and false. looks good, but we don't use that on other pages. should we? - ES-no
[x] page 74 - sam the butterfly - most pages that reference starter files have hot links.

Algebra pyret solution workbook

[x] p21 converting coe to arith - number 4 is wrong (@flannery-denny what's incorrect about it?) FD - In order to get this circle, you would need parentheses around 1 x -6. I looked at the asciidoc, but this is hardcoded into our coe -> expr infrastructure. Even though both expressions give the same answer (because multiplication is commutative) our infrastructure should insist on left to right order and insert parentheses when the circle overrules left to right order. The same should be true in how the algorithm handles addition.
[x] page 76 - converting coe to code - last code splits onto two lines. fixable?
[x] page 16 arith to coe to code challenge. first one code doesn't fit on one line. if either other column were a hair narrower it would. plenty of space for that in solution mode...

Algebra wescheme solutions LONG

[x] p9 - look at the first circle and notice how close the 4 and the 2 are. There is similar spacing for other circles on the page. It would be clear if the numbers were twice as far apart.
[x] page 41- Practicing contracts Domain & Range - why is the font of the highlighted text on this page inconsistent?
[x] page 132 - distance between (0,2) and (4,5) has a weird shadow of the COE
[x] p12 - The @fitb don't need to be so long for COE. And if they weren't so long, the numbers could be spaced more clearly.
[x] p23 - evaluating COE - for some reason 6 & 7 are identical (I know this is likely not a css issue)
[x] page 48 - triangle contrats sas - why is there a break in the bottom box of code?
[x] page 49 - star-polygon -why is there a break in the box of code?

Algebra wescheme workbook LONG

flannery-denny commented 3 years ago

@schanzer I think I've taken care of everything on this issue that is within my skillset

schanzer commented 3 years ago

@flannery-denny nice work!

I just pushed a bunch of fixes that cover most of the remaining issues. Re: parentheses - don't forget that Dorai added #:parens true as an option!

what do you feel is inconsistent about "Practicing Contracts: Domain & Range"? Currently all the lesson-specific vocabulary is highlighted. Is there a different highlighting scheme you'd prefer?
spacing on the circles of evaluation numbers is...harder. How critical is this item?

flannery-denny commented 3 years ago

@schanzer

Screen Shot 2021-09-24 at 9 23 23 PM

the font and size of the text for the contract and code are different. Seems they should be the same.
As for the spacing on the coe, I wouldn't let my students write it with that spacing because many of them would translate 4 2 as 42... If it's a royal pita, prioritize it as you wish, but I strongly suggest we fix it before we print more workbooks for pd in June.

schanzer commented 3 years ago

@flannery-denny I believe I've got the last of them. Can you confirm, and close the issue if so?

bootstrapworld / curriculum