search

boourns / synthmodes

Mobile-friendly cheat sheets for synthesizer modules
https://synthmodes.com
59 stars 25 forks source link

Added missing mode for Pico DSP and fixed small build issues #96

Closed vfilby closed 2 years ago

vfilby commented 2 years ago
  1. Added missing pitch shift delay more for Pico DSP
  2. Fixed a type that was causing test.sh to fail on file not found
  3. Using mkdir_p in render_web_data.rb since endorphines has subdirectories and fails on a clean build.
vfilby commented 2 years ago

Out of curiosity, it looks like the ./web/modules directory is built dynamically via the ./test.sh script, but is also checked into code. Is that intentional for the web/app build?

boourns commented 2 years ago

It's... not great. But yes, you're correct. The web deployment pulls the content directly out of the repository right now. I used it as part of the test as the easiest way to tell if the build was broken was to build it.

vfilby commented 2 years ago

Ok, I wasn't sure because some of the more recent endorphines content was showing as new files, so they wouldn't have been checked in when I cloned the repository.

I have some more additions to make, and I'll make sure the web content is checked in for those. My plan is to add a cheat sheet for the Pico DSP (Xodes mod), Acid Rain Switch Blade, and I would like to add one for the QU-Bit Bloom sequencer.

boourns commented 2 years ago

I likely have not released the website since adding the endorphines content.

Your additions sound fantastic. I have a few bugs to fix and should have time to contribute a cheat sheet myself, and when that is all committed I will do a new release of the iOS app. Thank you!