search

booxmedialtd / ws-action-parse-semver

GitHub action for parsing a tag following semantic versioning.
MIT License
11 stars 6 forks source link

feat: update to Node 16 #23

Closed andrew-welker closed 1 year ago

andrew-welker commented 1 year ago

Github is deprecating/removing Node 12 support. Node 16 does require using a minimum Actions Runner version of v2.285.0, which is available in GHES 3.4 or later.

Edit: GH is also deprecating setting outputs directly, instead preferring to use the ENV file to set outputs and state. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I've update both the @actions/core and @actions/github package to handle those updates as well.

Close #22

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tlangens commented 1 year ago

This updates deprecated packages but does not disuse set-output, leaving #22 still valid.

andrew-welker commented 1 year ago

My understanding from the GitHub blog post I linked is that updating the @actions/core package to at least 1.10.0 and continuing to use the setOutput function from the package does modify the action to not use set-output and use the new method. I'm also not seeing anywhere else that set-output is being used other than in actions-io file.

github-actions[bot] commented 1 year ago

🚀 [bumpr] Bumped! New version:v1.4.6 Changes:v1.4.5...v1.4.6