booya-at / OpenGlider

python library to build paragliders
GNU General Public License v3.0
65 stars 25 forks source link

Remove Unused Dependency: lxml #74

Open gdrosos opened 1 year ago

gdrosos commented 1 year ago

Summary

Hello @looooo,

I hope you're doing well! I've just opened this pull request that proposes the removal of the unused lxml dependency from the setup.py configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The lxml library was introduced in 6f6a83a. However it appears to be unused in the source code. It was added on the grounds that it was required indirectly by ezodf. However, it is already listed in ezodfs dependencies, making its declaration in OpenGlider redundant.

Instead, when OpenGlider is installed through pip (e.g. pip install -e .), pip will automatically resolve lxml through ezodf.

Removing this unused dependency will mitigate potential security risks and, most importantly, simplify the dependency management process.

Changes

Impact