Very panicky API, lots of `.expect` and `.unwrap`.

booyaa / wifiscanner

A crate to list WiFi hotspots in your area

Apache License 2.0

59 stars 34 forks source link

Very panicky API, lots of `.expect` and `.unwrap`. #1

Closed cristicbz closed 5 years ago

cristicbz commented 8 years ago

Tried this on Linux (which I since figured is not meant to be supported yet), but the failure mode is a panic. I noticed that all operations which may fail are unwrap'd.

Would be nice to have a wifiscanner::Error type and return a Result<Vec<Wifi>> instead.

(thanks for the crate, hope to get this on Linux!)

booyaa commented 8 years ago

Just released 0.2.0, less panicky and returning a Result<Vec> with a Error if run not run on OS X. Still need to fix the .expects when finding data boundaries.

Will keep this issue open until I've tidied up and refactor some more.

booyaa commented 8 years ago

Slow improving this with 0.3.0 still room for improvement. The lib needs breaking up.

Boscop commented 7 years ago

Any updates on this?