search

booyaa / wifiscanner

A crate to list WiFi hotspots in your area
Apache License 2.0
59 stars 34 forks source link

Switch to GitHub Action for lint, build and test #19

Closed booyaa closed 5 years ago

booyaa commented 5 years ago

No longer need to rely on 3rd party services like Travis, create a separate workflow file called ci.yml do not use any existing workflow if found.

See:

Acceptance criteria

Runs the following cargo commands on Linux and macOS (-latest virtual environment is sufficient)

b1zzu commented 5 years ago

Hi @booyaa can I work on this?

booyaa commented 5 years ago

Hi @booyaa can I work on this?

Yup go for it and thank you! Updated the issue to include acceptance criteria, let me know if you have any questions.

b1zzu commented 5 years ago

@booyaa we should tests on both linux and mac right?

booyaa commented 5 years ago

@booyaa we should tests on both linux and mac right?

Good spot, yup I've updated the acceptance criteria. Are you planning to use a strategy matrix to reduce code duplication? I've got an example if you've not used them before.

b1zzu commented 5 years ago

Yes I wanted to test check, fmt and clippy only on ubuntu with rust latest; and then use matrix to run the test against mac and ubuntu with rust latest, nightly and beta; wdyt?

booyaa commented 5 years ago

Yup, that sounds good to me!

On Wed, 2 Oct 2019 at 18:05, Davide Bizzarri notifications@github.com wrote:

Yes I wanted to test check, fmt and clippy only on ubuntu with rust latest; and then use matrix to run the test against mac and ubuntu with rust latest, nightly and beta; wdyt?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/booyaa/wifiscanner/issues/19?email_source=notifications&email_token=AABPCYAOEIUC5ISP6HW3SXTQMTIF3A5CNFSM4I4TFB6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFPGYY#issuecomment-537588579, or mute the thread https://github.com/notifications/unsubscribe-auth/AABPCYCSMHGGQTM4ZW5V5RLQMTIF3ANCNFSM4I4TFB6A .

-- Sent from Gmail BatMobile