boozallen / aissemble

Booz Allen's lean manufacturing approach for holistically designing, developing and fielding AI solutions across the engineering lifecycle from data processing to model building, tuning, and training to secure operational deployment
Other
34 stars 8 forks source link

BUG: Eliminate maven-enforcer-plugin related build cache warning #246

Closed d-ryan-ashcraft closed 3 months ago

d-ryan-ashcraft commented 3 months ago

Description

When building the plugin, we see the following warnings: (731 times on a full, clean build - this included deploy on CI as well!)

[INFO] --- install:3.1.2:install (default-install) @ aissemble-machine-learning-training ---
[INFO] Installing /Users/edwin/dev/aissemble-oss/aissemble/test/test-mda-models/test-machine-learning-model/aissemble-machine-learning-training/pom.xml to /Users/edwin/.m2/repository/com/boozallen/aissemble/aissemble-machine-learning-training/1.8.0-SNAPSHOT/aissemble-machine-learning-training-1.8.0-SNAPSHOT.pom
[INFO] Installing /Users/edwin/dev/aissemble-oss/aissemble/test/test-mda-models/test-machine-learning-model/aissemble-machine-learning-training/target/habushu.placeholder.txt to /Users/edwin/.m2/repository/com/boozallen/aissemble/aissemble-machine-learning-training/1.8.0-SNAPSHOT/aissemble-machine-learning-training-1.8.0-SNAPSHOT.habushu.placeholder.txt
[WARNING] Cannot find a Mojo parameter 'commandLineRules' to read for Mojo org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce {execution: enforce-maven}. This parameter should be ignored.
[WARNING] Cannot find a Mojo parameter 'commandLineRules' to read for Mojo org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce {execution: enforce-java}. This parameter should be ignored.
[WARNING] Cannot find a Mojo parameter 'commandLineRules' to read for Mojo org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce {execution: enforce-java-version}. This parameter should be ignored.
[WARNING] Cannot find a Mojo parameter 'commandLineRules' to read for Mojo org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce {execution: enforce-maven-version}. This parameter should be ignored.
[WARNING] Cannot find a Mojo parameter 'commandLineRules' to read for Mojo org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce {execution: enforce-helm-version}. This parameter should be ignored.
[INFO] Saved Build to local file: /Users/edwin/.m2/build-cache/v1/com.boozallen.aissemble/aissemble-machine-learning-training/bf6020107c519ab30573d34c39684b03e7623fb32b1038d5280433d998ce6443/local/buildinfo.xml

Background

While not directly hurting anything, they break our pattern of not having warnings or errors that we learn to ignore and should be removed.

This issue stems from a deprecated property in the maven-enforcer-plugin that we shouldn't be using in the first place. Ignoring it seems like the best course of action to remove the cognitive friction it creates in the build output.

Steps to Recreate

chang-annie commented 3 months ago

all test steps are passing!