boozallen / aissemble

Booz Allen's lean manufacturing approach for holistically designing, developing and fielding AI solutions across the engineering lifecycle from data processing to model building, tuning, and training to secure operational deployment
Other
34 stars 8 forks source link

BUG: Configuration Store: webhook cleanup job doesn't work in ArgoCD #311

Open csun-cpointe opened 2 months ago

csun-cpointe commented 2 months ago

Description

After successfully deploying the configuration store using ArgoCD, when delete the configuration-store app the webhook didn't get clean up.

Screenshot 2024-08-29 at 4 34 32 PM

Root Cause

helm.sh/hook: pre-delete is not supported by argocd. Ref: Helm Hooks/hook: pre-delete

Definition of Done

Test Instruction

Steps to Reproduce

Clear, specific, and detailed steps taken to enable reproduction of the bug for investigation.

Expected Behavior

A clear and concise description of the outcome you expected from the actions taken. The configuration store webhook should also be deleted.

Actual Behavior

A clear and concise description of the outcome you experienced from the actions taken. The configuration store webhook stays active

Additional Context

jaebchoi commented 2 days ago

DOD Completed with @cwoods-cpointe

jaebchoi commented 20 hours ago

Keeping this in backlog as this is less critical as leftover webhook wouldn't affect k8s resource generation in argo CD. Also ArgoCD have plan to support pre-delete hook See Here