search

boozallen / aissemble

Booz Allen's lean manufacturing approach for holistically designing, developing and fielding AI solutions across the engineering lifecycle from data processing to model building, tuning, and training to secure operational deployment
Other
34 stars 8 forks source link

#430 FIx data delivery steps not injecting smallrye when running test-data-delivery-spark-model #446

Closed jaebchoi closed 3 weeks ago

jaebchoi commented 3 weeks ago

We have disabled some data delivery steps as those steps are not injecting smallrye reactive messaging correctly.

It seems like any step with asynchronous type, no inbound messaging , and messaging outbound is having issue with running step execution.

Issue https://github.com/boozallen/aissemble/issues/430

ewilkins-csi commented 3 weeks ago

Do we know when this started to fail? Prior to 1.7, we were running the tests and this wasn't an issue. I mainly ask because the changes made here are things I would have expected to be around for awhile. So curious what changed since 1.7 that would require the new checks.

jaebchoi commented 3 weeks ago

@ewilkins-csi

Good callout on testing prior tags to see what causes this issue. Didn't think about that. Upon incremental testing of releases, I noticed that we don't have this issue up until 1.9.4. Which means 1.10 milestone caused this issue to fail.

I suspect this is due to java 17 upgrade issue. (I couldn't pinpoint exactly what specific module thou but most likely messaging) or even version upgrade of smallrye reactive message from 3.15 to 4.24

Given that you pointed out there are several bugs exists in the alerting and messaging, I think once those bugs are fixed, this issue might also be fixed as well.

I think we can send this as we know it is workaround and we can revisit on this issue once any messaging bug is finished to see if it fixes or not.