Fix svgbob diagrams in dark mode

boozook / mdbook-svgbob

SvgBob mdbook preprocessor which swaps code-blocks with neat SVG.

Mozilla Public License 2.0

76 stars 8 forks source link

Fix svgbob diagrams in dark mode #28

Open hmn53 opened 9 months ago

hmn53 commented 9 months ago

Closes https://github.com/boozook/mdbook-svgbob/issues/22

Currently, the SVG text elements receive the default color, black, which is not readable on dark mode.

This PR adds a one-liner CSS fix to apply the foreground css variable (var(--fg)) to the svg text element to make svg text legible and visible.

mgeisler commented 9 months ago

When I downloaded it, I got

Compiling proc-macro2 v1.0.67

and the test failure is with

Compiling proc-macro2 v1.0.47

I guess this is because of the Cargo.lock file?

hmn53 commented 9 months ago

Yes, that seems to be the issue.

mgeisler commented 9 months ago

Yes, that seems to be the issue.

I would suggest making a separate PR that updates the Cargo.lock file so we can get CI running again :smile: Then rebase this on top and we should be back in business.