search

bopen / c3s-eqc-toolbox-template

CADS Toolbox template application
Apache License 2.0
5 stars 4 forks source link

New method for trend calculation in XCH4/XCO2 satellite dataset (time series decomposition) #69

Open paolocristofanelli opened 1 year ago

paolocristofanelli commented 1 year ago

Describe the solution you'd like

In the future, for trend calculation of greenhouse gas, we should implement this method https://gml.noaa.gov/ccgg/mbl/crvfit/crvfit.html

A Python class for computing the curves is available at https://gml.noaa.gov/aftp/user/thoning/ccgcrv/

paolocristofanelli commented 1 year ago

Hello @malmans2 do you have any plan/roadmap to implement a solution for this trend calculation method?

malmans2 commented 1 year ago

I haven't looked into this yet, I'll take a look ASAP. Do you have a deadline?

paolocristofanelli commented 1 year ago

@malmans2 no deadline so far. But I guess that this can be requested soon by the data provider...

malmans2 commented 8 months ago

Hi @paolocristofanelli,

Sorry, I just realised that I never looked into this.

The library that you shared is not packaged, and therefore we can't easily implement it in our software or make it available in the EQC environments. Also, I'm not sure if it works well with the other packages we are using for EQC (e.g., xarray), and it's possible that we need to re-write it from scratch.

As it looks like the implementation is not straightforward, I'd wait until you are sure that you need this feature. If we decide to invest time on implementing this, we should definitely coordinate with ECMWF.

paolocristofanelli commented 6 months ago

Hi @malmans2, sorry I did not reply. Ok. Let's wait for ECMWF feedbacks after this first round of Quality Assessment submission. Can we keep the issue open?

malmans2 commented 6 months ago

Sure, no problem.