search

bopen / xarray-sentinel

Xarray backend to Copernicus Sentinel-1 satellite data products
Apache License 2.0
222 stars 22 forks source link

Expose burst data #14

Closed corrado9999 closed 3 years ago

corrado9999 commented 3 years ago

See #9

alexamici commented 3 years ago

I did a few comments on style and naming, but the real BIG point is the type hints. I suggest to add the parse_tag_dict function in main ASAP.

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (11f846a) into main (31d0ed6) will increase coverage by 1.00%. The diff coverage is 95.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   93.16%   94.17%   +1.00%     
==========================================
  Files           6        7       +1     
  Lines         366      481     +115     
==========================================
+ Hits          341      453     +112     
- Misses         25       28       +3
Impacted Files Coverage Δ
tests/test_xarray.py 88.46% <73.91%> (-11.54%) :arrow_down:
xarray_sentinel/sentinel1.py 95.78% <97.67%> (+2.80%) :arrow_up:
tests/test_esa_safe.py 100.00% <100.00%> (ø)
tests/test_sentinel1.py 100.00% <100.00%> (ø)
xarray_sentinel/esa_safe.py 90.78% <100.00%> (+1.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31d0ed6...11f846a. Read the comment docs.