bopen / xarray-sentinel

Xarray backend to Copernicus Sentinel-1 satellite data products
Apache License 2.0
221 stars 22 forks source link

Implement drop_variables key. #34

Closed aurghs closed 3 years ago

aurghs commented 3 years ago

Currently, the drop_variabiales key in open_dataset is ignored. It should be implemented.

alexamici commented 3 years ago

This is low priority as data access is always lazy, so there's no performance penalty in reading all the variables, and the main reason for dropping variables is to avoid crashes due to badly encoded of corrupted data.

aurghs commented 3 years ago

yes, but this key is not optional in Xarray backend interface. So we need at least a warning to advise that it is not implemented