bopen / xarray-sentinel

Xarray backend to Copernicus Sentinel-1 satellite data products
Apache License 2.0
221 stars 22 forks source link

32 add swath data in group iw #39

Closed aurghs closed 3 years ago

aurghs commented 3 years ago

close #32 For now the coordinates used for the swath are line and pixel

codecov-commenter commented 3 years ago

Codecov Report

Merging #39 (5ddbc1e) into main (e74f5bd) will increase coverage by 0.29%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   93.39%   93.69%   +0.29%     
==========================================
  Files           7        7              
  Lines         530      555      +25     
  Branches       60       65       +5     
==========================================
+ Hits          495      520      +25     
+ Misses         19       18       -1     
- Partials       16       17       +1     
Impacted Files Coverage Δ
tests/test_esa_safe.py 100.00% <100.00%> (ø)
tests/test_xarray.py 100.00% <100.00%> (ø)
xarray_sentinel/sentinel1.py 96.09% <100.00%> (+0.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e74f5bd...5ddbc1e. Read the comment docs.

alexamici commented 3 years ago

For now the coordinates used for the swath are line and pixel

This looks correct, but then we need to add line and pixel to all other metadata as well. Or there is no way to connect them.

aurghs commented 3 years ago

I agree