bopen / xarray-sentinel

Xarray backend to Copernicus Sentinel-1 satellite data products
Apache License 2.0
219 stars 22 forks source link

Add initial sentinel1 accessor that raises when not used on backend Dataset (more or less) #46

Closed alexamici closed 3 years ago

alexamici commented 3 years ago

Objectives for the accessors are:

codecov-commenter commented 3 years ago

Codecov Report

Merging #46 (60eeaaf) into main (988a162) will increase coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   93.12%   93.32%   +0.19%     
==========================================
  Files           7        7              
  Lines         538      554      +16     
  Branches       62       64       +2     
==========================================
+ Hits          501      517      +16     
  Misses         20       20              
  Partials       17       17              
Impacted Files Coverage Δ
tests/test_xarray.py 100.00% <100.00%> (ø)
xarray_sentinel/sentinel1.py 95.02% <100.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 988a162...60eeaaf. Read the comment docs.

aurghs commented 3 years ago

this PR seems to be too big. I think we can split it into smaller ones. One for each point of the list.

alexamici commented 3 years ago

I agree.