bopen / xarray-sentinel

Xarray backend to Copernicus Sentinel-1 satellite data products
Apache License 2.0
219 stars 22 forks source link

Add ascending node time #68

Closed aurghs closed 2 years ago

aurghs commented 2 years ago

More work on #36.

alexamici commented 2 years ago

@aurghs unit test fails due to README using burst_index, you may run make doc-test to test the README.

Please run black, you may run make to fix code formatting and run all tests.

codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (46fc55f) into main (aff094a) will decrease coverage by 2.11%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   95.67%   93.56%   -2.12%     
==========================================
  Files          12       12              
  Lines         694      715      +21     
  Branches       71       75       +4     
==========================================
+ Hits          664      669       +5     
- Misses         16       30      +14     
- Partials       14       16       +2     
Impacted Files Coverage Δ
xarray_sentinel/sentinel1.py 90.97% <33.33%> (-5.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aff094a...46fc55f. Read the comment docs.

alexamici commented 2 years ago

@aurghs very nice!

alexamici commented 2 years ago

@aurghs one more thing: in clip_burst_dataset it would be nice to add an attribute with the azimuth_anx_time of the burst. Not sure what is best whether the first line of the central line, or maybe both.