search

bopen / xarray-sentinel

Xarray backend to Copernicus Sentinel-1 satellite data products
Apache License 2.0
221 stars 22 forks source link

Propose adding the relative orbit to the group name #8

Closed alexamici closed 3 years ago

alexamici commented 3 years ago

Group names do not uniquely identify a burst, it possible (even if unlikely) that two relative orbits will have identical group names for different bursts, e.g. group="IW2/N433_W0120_VV". Adding the relative orbit to the group structure will make all group names longer and more complex, but unique: e.g. group="22/IW2/N433_W0120_VV" and group="169/IW2/N433_W0120_VV".

This is a trade-off. I'm not sure what naming scheme is best.

We could even accept both (causing even more confusion).

aurghs commented 3 years ago

The relative orbit is useful mainly to identify uniquely the bursts, I would rather add the orbit in the burst name, for example: group="IW2/N433_W0120_VV_T22"

alexamici commented 3 years ago

The relative orbit is useful mainly to identify uniquely the bursts, I would rather add the orbit in the burst name, for example: group="IW2/N433_W0120_VV_T22"

@aurghs I agree with the idea, but prefer: group="IW2/R022_N433_W0120_VV" (R for "relative orbit" and keep the name to a fixed length).

I also noticed that the polarisations should really be bands of the same dataset, not different datasets, but that is another issue (they have identical dimensions and coordinates)

alexamici commented 3 years ago

I'll close the PR as "rejected" and open an issue with the discussion.

(@aurghs ok, I see why having an issue is better that a PR :/)