search

bopjesvla / hitch

https://hitchmap.com
GNU Affero General Public License v3.0
8 stars 2 forks source link

Feat/sidebar #67

Closed tillwenke closed 2 months ago

tillwenke commented 3 months ago

did it the easy way. could you make the menu appear by default when accessing the site? @bopjesvla

bopjesvla commented 3 months ago

I have quite a few comments. Don't be disparaged, you're on the right track.

could you make the menu appear by default when accessing the site?

That seems ill-advised, most people visiting just want to use the map.

We can move the credits to the menu, and put the menu button in the bottom-right corner.

Another thing: a menu shouldn't have this much unstructured text. Also, URLs shouldn't be shown as plain text. They should be links with a human-readable label. I like the use of the Github icon though.

Maybe replace the unstructured text wuth the following sections:

Credits (everything in the footer)

Links (Recent changes, GITHUBICON Contribute, GITHUBICON Report bugs)

Maybe a changelog?

I think there were other things we held off because we didn't have a menu, it might be worth it to search the issues for "menu"

tillwenke commented 3 months ago

done. @bopjesvla you can make any changes that you find more visually appealing : )

bopjesvla commented 2 months ago

If put in the top-right, the menu touches the search bar on small screens, even though it looks good on a big screen. I'm moving the menu button to the horizontal row of buttons for now, lmk if you find a better place

bopjesvla commented 2 months ago

Merged :)