bopjesvla / hitch

https://hitchmap.com
GNU Affero General Public License v3.0
8 stars 2 forks source link

Add user accounts (fully optional) #79

Open bopjesvla opened 2 months ago

bopjesvla commented 2 months ago

We've had quite a few requests for user pages with all of their reviews, so I guess it makes sense to add user accounts

No need to make them mandatory given the lack of spam/abuse

bopjesvla commented 2 months ago

User has email, password, username

User page shows user reviews + all Hitchmap reviews made before the user creation date made with that same nickname + all reviews with same Hitchwiki username

For the last two categories, add a disclaimer that these are not necessarily by the same person. Might even consider collapsing them

tillwenke commented 1 month ago

I d advocate using hitchwiki accounts if possible.

tillwenke commented 1 month ago

maybe like this https://www.mediawiki.org/wiki/OAuth/For_Developers

bopjesvla commented 1 month ago

I remember that getting a Hitchwiki account was a hassle, requiring manual verification by an admin.

Hitchwiki also has super aggressive Cloudflare settings, so it might not be usable all around the world. Even regular Cloudflare settings might be too much for our user accounts, as we don't use it ourselves and some users/countries continue to have trouble with it.

bopjesvla commented 1 month ago

Also, like Hitchmap, Hitchwiki isn't funded at all and there's no guarantee it'll outlive Hitchmap. I'm cool with providing Hitchwiki logins as an option, but it shouldn't be the only option.

bopjesvla commented 1 month ago

Flask-Security, https://flask-security-too.readthedocs.io/en/stable/features.html , has recently been picked up by the core Flask team. I think is definitely the way to go now.

bopjesvla commented 1 month ago

In the initial implementation, I suggest:

Then, on the front-end:

bopjesvla commented 1 month ago

hitchmap.com/#user:bob should also show reviews that were made under the nickname Bob (these were necessarily written before the user was registered)

bopjesvla commented 1 month ago

Alternatively, we can ask new users to select which reviews under the same nickname are theirs