search

boppescripting / b-discordbooster

A beyond simple free script for server owners to give a reward to their discord boosters!
GNU General Public License v3.0
11 stars 1 forks source link

Moving Discord Bot Token and Guild ID to server side and redoing some basic stuff. #1

Closed Ruby-LK closed 11 months ago

Ruby-LK commented 11 months ago

This pull request ensures that client modders/dumpers won't have access to the bot token because it has been moved from the config to the server side Edit : Changed the notification function to event,

lenzh commented 11 months ago

way better doing this! this needs to be merged

boppescripting commented 11 months ago

Hey... thanks for the pull request! I have a couple questions...

  1. Why are we moving the token and server id to the server-side file? The config is only loaded on the server-side regardless in the fxmanifest so the client has no access to it.

  2. Is switching from the notify function to the event for backwards-compatibility with older versions of qb-core?

Ruby-LK commented 11 months ago

Hello there, Thanks for the response.

  1. Just noticed that config is loading in server side. So that 2 changes not required at all.
  2. Yes made that change for the backwards-compatibility with older versions of qb-core cuz some versions didn't work with the function. I had some scripts in my previous servers with the same but didn't work well because of the same thing. Will test more to confirm.

Thanks for your response again.

Ruby-LK commented 11 months ago

Hello again, Did some search on previous versions of qb-core and confirmed that current versions has the compatibility for the function. So both changes are not required.

So can close this now. Thanks again for the response.