search

boppreh / keyboard

Hook and simulate global keyboard events on Windows and Linux.
MIT License
3.8k stars 433 forks source link

Removed administrator check for macs. #502

Closed alanxoc3 closed 2 years ago

alanxoc3 commented 2 years ago

I tested it. It isn't needed. Enforcing administrator is actually worse for people that have alternate keyboard layouts based on my testing. When you enforce administrator, I think the library is assuming the administrator's keyboard layout which is probably qwerty and I don't know how to or if it's possible to change that to something else. But when you run the library under the actual user, it uses that user's keyboard mapping (tested with dvorak).

Looking at the commit history, I'm guessing the check was there because someone copied the linux setup files to create the mac ones. But I don't actually know for sure.

boppreh commented 2 years ago

Makes sense, thanks for testing it yourself. Merged.

KeygenLLC commented 2 years ago

I just installed from pip and from git. It still fails to load for me without sudo on Mojave. Is this change not live yet?

Thanks

alanxoc3 commented 2 years ago

It doesn't look like it's live yet. Did you try this?

git clone git@github.com:boppreh/keyboard.git
cd keyboard
pip install .
KeygenLLC commented 2 years ago

Using anaconda env, think I did pip install git+https://github.com/boppreh/keyboard