search

boppy / SolrBundle

Solr-Integration into Symfony >= 4.3 and Doctrine (forked from floriansemm/solr-bundle)
MIT License
0 stars 1 forks source link

Fix Unit Tests #2

Open boppy opened 3 years ago

boppy commented 3 years ago

After a Doctrine-Update the unit test do not work anymore.

burki commented 3 years ago

I have little experience with phpunit.

The first thing I noted (due to "require-dev": { ... "phpunit/phpunit": "^7.0" } in composer.json) was the need for changing extends \PHPUnit_Framework_TestCase to extends \PHPUnit\Framework\TestCase as well as the need to update a few method signatures due to changes in Solarium.

Did you make such changes in your local installation as well? If so, which failed test would you like me to look into?

boppy commented 3 years ago

To be honest: I did not dig into this yet. I just got the info about not working Tests from my teammate.

The final result should be working set of tests. As there is already a massive suite of tests from the original author, I plan to have all of them working again, if possible.

burki commented 3 years ago

Have a look at https://github.com/DaanBiesterbos/SolrBundle/commit/03c221fb1fe17502f23c9027ee52409ed234ec25#diff-76a65bee09a53e88fbda42549de72ae65dbdf288054e4c63d2d74fe719a720d2 It is a massive commit but he seems to have started converting all the tests-cases. Let me know what you think is the best way to coordinate this update (e.g. a first pull request which gets all the tests running again and then look into the various issues). It might make sense to work on this in a separate branch?

boppy commented 3 years ago

It would make much sense to not distribute this module to different repos.

Perhaps @DaanBiesterbos could state if he is interested in maintaining the SolrBundle in the future. If so, I would suggest to create an Org in Github to have the possibility to "join forces" and provide the best Solr bundle possible.

Since the company I work for will use this module in a production system that is currently in development, I will surely have an eye on the module once the system is stable, and keep updating it. Current state of dev is, that we have not yet started the indexing part, so I do not yet have a closer look into this Bundle.

Regarding your questions:

DaanBiesterbos commented 3 years ago

Hi Boppy,

Sounds like a good idea. The diff is pretty big indeed. A lot of changes are simple and/or cosmetric. Code style fixes etc. The changes so far are all pretty safe. The company I work for was using the original repository. We have been using the fork in production for a couple of weeks now.

I did manage to upgrade a number of dependencies to up to date versions as well. There is still some code I started working on butI did not push just yet. Thisversion is using Solarium 4 still, but in order to use Solr Cloud we'll need Solarium 6 if I remember correctly.

DaanBiesterbos commented 3 years ago

The motivation for forking the bundle was to fix a performance issue and to get rid of unstable -/ archived dependencies. I am fairlysure I encountered and fixed this doctrine issue as well.

We can still change the name but to get started I went ahead to create a new organisation. PHPSolr seemed like a decent name and was still available. https://github.com/orgs/PHPSolr