boradesanket13 / Blaze

Weather application with geolocation using OpenWeatherAPI and RestCountries API
https://blaze-silk.vercel.app/
MIT License
17 stars 44 forks source link

Optimization JS code #117

Closed UrijHoruzij closed 1 year ago

UrijHoruzij commented 1 year ago

Optimized the js code.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blaze ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 11:54AM (UTC)
netlify[bot] commented 1 year ago

Deploy Preview for sanket1308-weather-app ready!

Name Link
Latest commit a759dbf33f98ad0bd3d786f5f5ac5aa03f1c712d
Latest deploy log https://app.netlify.com/sites/sanket1308-weather-app/deploys/63d9017079a06b000808e13b
Deploy Preview https://deploy-preview-117--sanket1308-weather-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | 336f3ef244de851665e66bad40726463b48dd10f | script.js | [View secret](https://github.com/boradesanket13/Blaze/commit/336f3ef244de851665e66bad40726463b48dd10f#diff-9a9569e9d73f33740eada95275da7f30R28) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | 336f3ef244de851665e66bad40726463b48dd10f | script.js | [View secret](https://github.com/boradesanket13/Blaze/commit/336f3ef244de851665e66bad40726463b48dd10f#diff-9a9569e9d73f33740eada95275da7f30L9) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/open_weather_map#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!