boradesanket13 / Blaze

Weather application with geolocation using OpenWeatherAPI and RestCountries API
https://blaze-silk.vercel.app/
MIT License
17 stars 44 forks source link

initial state shows user's location weather data #64

Closed Tobshub closed 2 years ago

Tobshub commented 2 years ago

Changes made

Issues solved

57

netlify[bot] commented 2 years ago

Deploy Preview for sanket1308-weather-app ready!

Name Link
Latest commit 0b32d990a9f1a7a9838728487fb34507fbb4734b
Latest deploy log https://app.netlify.com/sites/sanket1308-weather-app/deploys/634300b6357f170008474b75
Deploy Preview https://deploy-preview-64--sanket1308-weather-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | 0b32d990a9f1a7a9838728487fb34507fbb4734b | script.js | [View secret](https://github.com/Sanket1308/Weather-App/commit/0b32d990a9f1a7a9838728487fb34507fbb4734b#diff-9a9569e9d73f33740eada95275da7f30R22) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/open_weather_map#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

boradesanket13 commented 2 years ago

Great job, @Tobshub . Really nice implementation. 🚀 But, this branch has conflicts that must be resolved. It will be great if you fix that and make another PR. ✔

Tobshub commented 2 years ago

Got it @Sanket1308, new PR coming up