console clear & solved bug

DhavalDobariya333 commented 2 years ago

Fixed issue: #69

console cleared.
the bug was solved when the wrong city was entered and after did not display the correct city info.
and improve some code

netlify[bot] commented 2 years ago

Deploy Preview for sanket1308-weather-app ready!

Name	Link
Latest commit	ad2770612f90318a1f41bd19b921411d8fe722f6
Latest deploy log	https://app.netlify.com/sites/sanket1308-weather-app/deploys/63594d7009bc6e0008c0d567
Deploy Preview	https://deploy-preview-79--sanket1308-weather-app.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

boradesanket13 commented 2 years ago

Great job, @DhavalDobariya333 . Really nice implementation. 🚀 But, this branch has conflicts that must be resolved. It will be great if you fix them and make another PR. ✔

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | OpenWeatherMap Token | ad2770612f90318a1f41bd19b921411d8fe722f6 | script.js | [View secret](https://github.com/Sanket1308/Weather-App-App/commit/ad2770612f90318a1f41bd19b921411d8fe722f6#diff-9a9569e9d73f33740eada95275da7f30R23) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/open_weather_map#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

DhavalDobariya333 commented 2 years ago

I resolved the conflict but got errors in the checks. Do I have to remake the new pull request or these unsuccessful checks can be solvable here?

Give me some guidance what error is this?

boradesanket13 / Blaze