boramalper / himawaripy

Set near-realtime picture of Earth as your desktop background

http://labs.boramalper.org/himawaripy

MIT License

1.62k stars 239 forks source link

Fixed xfce4 support. #31

Closed rbong closed 8 years ago

rbong commented 8 years ago

This should fix #4 and possibly #15. This technically also adds the support for multiple monitors in xfce as well.

boramalper commented 8 years ago

Let's see if this fixes #4 and #15, then I will merge.

Thank you!

rbong commented 8 years ago

4 has been fixed and #15 is not replying.

The newest commit will preserve the previous behaviour. The previous option string used has been placed inside the xfce_displays array, so that this pull request will not break the script for anyone.

boramalper commented 8 years ago

Thank you!

I'm merging this now, but maybe we can also parse the output of xfconf-query --channel xfce4-desktop --list | grep last-image and automatically set background for every display. Not sure if it's a good idea though, what do you think?

rbong commented 8 years ago

I think there's a whole lot of displays in that command. Maybe just adding /backdrop/screen0/monitorHDMI-0/last-image and /backdrop/screen0/monitorLVDS0/last-image (there's no hyphen but this is correct) to that array by default would be enough. If someone is using a second workspace, tty login, or monitor, they'll probably know that they need to configure the script a bit.

In general, I think if there's going to be more multi-monitor support there needs to be a more robust configuration framework.

boramalper commented 8 years ago

I'm planing to create a Python library for detecting desktop environment and setting background. It may even evolve by time to include other supposed-to-be-simple OS related functions.

I never imagined that such a trivial task could be that complicated...