PyPI packaging - Githubissues

boramalper / himawaripy

Set near-realtime picture of Earth as your desktop background

http://labs.boramalper.org/himawaripy

MIT License

1.62k stars 239 forks source link

PyPI packaging #51

Closed desbma closed 8 years ago

desbma commented 8 years ago

Make all config dynamic by using command line parameters instead of static source file (fixes #48)
Changes to allow packaging for PyPI (fixes #50)

Once merged, To publish package on PyPI:

Create an account
tag version with git tag -m "Version 1.2.0" 1.2.0 && git push --tags, this will automatically create a release with a source tarball on GitHub
Install pandoc sudo apt-get install pandoc && pip3 install pypandoc, this allow conversion of the README to RST format used by PyPI
In source directory, run python3 setup.py sdist register upload

Package should then be available on PyPI and installable with pip install himawaripy.

boramalper commented 8 years ago

I'm sincerely sorry for being so late, but I have finals coming in three weeks so I cannot spend time on anything else but studying.

After exams, I'll have enough time to spend on my projects, but for now, I can only apologize. Thank you so much!

desbma commented 8 years ago

No worries, we all have a life outside of pet projects :)

boramalper commented 8 years ago

Can you please open separate pull request for each change (not necessarily commit, but you changed a lot of thing and I don't want to merge them all together).

Just one thing: let's keep the configuration file for the backwards compatibility, and make command lines arguments to override. I don't want to break working setups.

Also https://github.com/boramalper/himawaripy/pull/51/commits/a4a85d496e97c428ea97cbd37f3c27a346d2901e#r62180029

Thanks a lot for your hard work, I really appreciate it!

desbma commented 8 years ago

Just one thing: let's keep the configuration file for the backwards compatibility, and make command lines arguments to override. I don't want to break working setups.

Unfortunately this is not a config file, this is a module that is imported. Clean packaging requires that configuration is separated from code that is why I added the command line parameters is the same pull request.

If backwards compatibility is a must for you, you can safely reject this pull request, I won't be mad as I am satisfied with my own changes.

boramalper commented 8 years ago

Unfortunately this is not a config file, this is a module that is imported. Clean packaging requires that configuration is separated from code that is why I added the command line parameters is the same pull request.

I agree, nevertheless I would like to keep it backwards compatible.