search

boramalper / himawaripy

Set near-realtime picture of Earth as your desktop background
http://labs.boramalper.org/himawaripy
MIT License
1.62k stars 239 forks source link

Added check if the image changed sice last download #62

Closed vician closed 8 years ago

vician commented 8 years ago

I've added control if the image have been changed since last download.

boramalper commented 8 years ago

It would be better if you opened several PRs for different changes, but here are my comments:

  1. Do we need a check if the image changed since last download? If you execute script in every 10 minutes, the image is guaranteed (well, very likely I mean) to be changed, since they update it in every 10 minutes.
  2. Wallpaper scaling is a great catch, thank you! Can you please open another PR and make sure to add your name to the AUTHORS list. :)
  3. I really want to keep himawaripy as simple as possible and while offering a installation script is a great idea, it's also an another responsibility burden. If you think that installation instruction in README lacks something, feel free to add or change though.

Thanks a lot for your contribution!

vician commented 8 years ago

Thanks for your feedback, I will do it as you described.

The installation script is for my purposes, I didn't want to include it to the pull request, sorry.