search

boramalper / magnetico

Autonomous (self-hosted) BitTorrent DHT search engine suite.
http://labs.boramalper.org/magnetico/
GNU Affero General Public License v3.0
3.06k stars 344 forks source link

integrating circleci #228

Closed lruggieri closed 5 years ago

lruggieri commented 5 years ago

Enables circleci.

image

ad-m commented 5 years ago

Why CircleCI (nor GitHub Action, nor TravisCI, nor Azure Pipelines)?

lruggieri commented 5 years ago

@ad-m From what I see this project already has travis and appveyor. Travis and CircleCI are the 2 most used CI tools, but I could not say which one fits best on magnetico for the moment. With this PR I just wanted to start making a comparison between the 2, but maybe it's only creating more confusion? Did not try GitHub one yet.

ad-m commented 5 years ago

If the project has TravisCI and AppVeyor currently integrated, why should one more be integrated? What are the benefits and advantages of this?

lruggieri commented 5 years ago

Merging this PR would likely have no benefit, if TravisCI is already the chosen one. But then why is there an appveyor.yml, which is not passing? I was thinking having these 3 together would be nice for making a comparison.

ad-m commented 5 years ago

I don't know AppVeyor, but it seems to me that it is a CI system that successfully tests on the Windows platform. TravisCI successfully performs tests on the Linux platform. In this case, both complement each other, not repeat.

I think that instead of introducing another CI system and counting on the fact that one system will work, it is necessary to fix the tests to give reproducible results (for developers before-push and in the CI system after-push).

lruggieri commented 5 years ago

Agreed. Did not think about the windows/linux difference. Closing this PR.

Regarding the travis file. I took a look and there are 2 problems:

will look further into it.