search

boratanrikulu / eternity

A minimalist Hugo theme designed for portfolio sites.
https://eternity.bora.sh
MIT License
237 stars 78 forks source link

Landing pics #14

Closed fabienli closed 1 year ago

fabienli commented 1 year ago

Hello, for my own website, I needed a capability to add some pictures on the welcome page, with direct links to some "featured" tags.

Here is a proposal to optionally add in the main _index.html a "featuredTags:" parameter that will achieve this: featuredTags Sample when the "featuredTags" parameter is not provided, the default layout is used, without any change compared to the current standard layout.

Let me know what do you think about this, and if such feature could be integrated in the main branch.

boratanrikulu commented 1 year ago

Hi! @fabienli

Thank you for the PR!
I didn't understand use case of this featuredTags feature. IMO, the screenshot looks like a bit non-minimalist. Are you looking for a way to show tag pages on Landing page?
If you aim to bypass landing page and show the site directly, you can use bypassWelcomePage param

fabienli commented 1 year ago

Hi @boratanrikulu, indeed the welcome page is less minimalist with this change. What I'd like to have is a few pre-selected tags, and 1 cover image for each, then clicking on one of those cover images will link to the relevant tag's url.

bypassWelcomePage param is rather a mean to directly jump to the main page with all its pictures.

In the sample attached above in this PR, you cab see two pictures, linked with the two tags: "people" and "nature"; clicking on each picture would display the page /tag/people or /tag/nature.

I'd understand that what I'm doing with this PR might not be of interest for all Eternity users. So I let you advise whether you think such kind of feature could be part of your repo, or if I should simply keep this as a customized version within my fork.

boratanrikulu commented 1 year ago

I see. Okay, I will merge this PR.