borchero / switchboard

Kubernetes Operator for Automatically Issuing DNS Records and TLS Certificates for Traefik Ingress Routes.
MIT License
155 stars 15 forks source link

fix: upgrade traefik client library to support new resource packaging #159

Closed christian-vdz closed 7 months ago

christian-vdz commented 8 months ago

Motivation

As it stands, Switchboard cannot work with newer versions of Traefik as describe in https://github.com/borchero/switchboard/issues/111. This change patches the project to include the newer version of the Traefik client library allowing it to operate with newer versions of traefik.

Resolves https://github.com/borchero/switchboard/issues/111

Explanation

This change upgrades the Traefik client library, patches the various files that use the Traefik, and finally updates the ClusterRole defined in the helm chart to support watching the appropriate resources.

Changes

Checklist

christian-vdz commented 8 months ago

@borchero can you approve the workflow run?

codecov[bot] commented 8 months ago

Codecov Report

Merging #159 (5365682) into main (7006eb4) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/borchero/switchboard/pull/159/graphs/tree.svg?width=650&height=150&src=pr&token=CI8KJLDRUP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert)](https://app.codecov.io/gh/borchero/switchboard/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert) ```diff @@ Coverage Diff @@ ## main #159 +/- ## ======================================= Coverage 71.84% 71.84% ======================================= Files 12 12 Lines 380 380 ======================================= Hits 273 273 Misses 88 88 Partials 19 19 ``` | [Files](https://app.codecov.io/gh/borchero/switchboard/pull/159?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert) | Coverage Δ | | |---|---|---| | [internal/controllers/ingressroute.go](https://app.codecov.io/gh/borchero/switchboard/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert#diff-aW50ZXJuYWwvY29udHJvbGxlcnMvaW5ncmVzc3JvdXRlLmdv) | `50.00% <ø> (ø)` | | | [internal/controllers/utils.go](https://app.codecov.io/gh/borchero/switchboard/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert#diff-aW50ZXJuYWwvY29udHJvbGxlcnMvdXRpbHMuZ28=) | `59.09% <ø> (ø)` | | | [internal/switchboard/hosts.go](https://app.codecov.io/gh/borchero/switchboard/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert#diff-aW50ZXJuYWwvc3dpdGNoYm9hcmQvaG9zdHMuZ28=) | `90.62% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/borchero/switchboard/pull/159?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/borchero/switchboard/pull/159?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert). Last update [7006eb4...5365682](https://app.codecov.io/gh/borchero/switchboard/pull/159?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Borchert).
christian-vdz commented 8 months ago

Nice, CI passes 😍 do you know what exactly was the fix?

I don’t understand why it works now, I did not change related to that CI job since last week.

christian-vdz commented 8 months ago

Hello @borchero, now that the CI passes, can you take the lead on merging this MR and creating a new release? I'd be happy to test it on my lab ASAP! ;)

borchero commented 7 months ago

I'm briefly taking care of all the dependabot PRs and will publish a new release 0.6.0 tonight :)

borchero commented 7 months ago

Here we go: https://github.com/borchero/switchboard/releases/tag/v0.6.0 :smile: sorry again for the suboptimal maintenance recently.

christian-vdz commented 7 months ago

Here we go: https://github.com/borchero/switchboard/releases/tag/v0.6.0 😄 sorry again for the suboptimal maintenance recently.

No worries, thank you for taking the time!
I've tested it and it works 🥳